fix: loader js does not see other preview types #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thats awesome! Thanks for your contribution. Could you add test cases also? 🙏 The tests are in loader.tests.js in the same folder. |
zakharchenkoAndrii
force-pushed
the
fix/loader-script
branch
2 times, most recently
from
5df8391 to
d493211
Compare
done 😉 |
zakharchenkoAndrii
force-pushed
the
fix/loader-script
branch
from
d493211 to
80cf70f
Compare
|
I don't have much time now but soon I'll check it. |
|
@zakharchenkoAndrii nice change, thanks! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #295
What I did
changed loader a bit
How to test
Create files with different extensions. The generated file should not fail to populate with decorators and parameters