refactor: some adjustments to safe area styling #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
heres a few small iterations on your changes @pvinis what do you think? |
dannyhw
commented
Jul 15, 2022
dannyhw
commented
Jul 15, 2022
| @@ -20,5 +20,5 @@ export const parameters = { | |||
| }; | |||
|
|
|||
| const styles = StyleSheet.create({ | |||
| container: { padding: 8, flex: 1 }, | |||
| container: { /* padding: 8, */ flex: 1 }, | |||
There was a problem hiding this comment.
this is where the padding was coming from btw
dannyhw
force-pushed
the
refactor/minor-change-to-safe-area
branch
from
0178478 to
65f9d2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
as a follow up to #345 I've added some changes to make the no safe area settings only apply to the preview and to make it so the navigation bar doesn't float.
This works by having the safe area insets for the navigation bar when the ui is visible but when you hide the ui then the full screen can be used
How to test
run the example app and open the outside safe area story
With UI hidden:
With UI Visible