feat: add number feedback to range slider, minor change onSlidingComplete #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CezarCobuz
changed the title
|
Thanks for your contribution 🙏🙇♂️. Looks good! Only thing is I'd like to see how it looks on Android too. I can give it a quick test tomorrow probably. |
Here is a preview on android: |
|
thanks @CezarCobuz sorry for the delay, having a look now! |
|
There is some strange behaviour with the slider on android, I don't think its caused by your changes though. |
|
Made a small adjustment, hope you don't mind!
Great contribution, thanks again 🙇 |
|
now live in 6.0.1-beta.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: discussion-334
What I did
Added text value for number range based on this discussion
Non-related to discussion: changed onSlidingComplete to onValueChange for faster feedback.
How to test
Can be testing using existing Number control > Range
range.rn-sb.mov