-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed inconsistent control type for 'radio' #309
Conversation
Changed the radio control to work with both Mobile and Web by changing the ControlType string of `radios` to `radio`.
Thanks for your contribution 🙇♂️. Will properly review soon. Seems ok to me. I was thinking it could work for both radios and radio though. Also please update the example in the example app :). |
I thought having it work with both radio and radios would create unnecessary confusion. So I chose to use the control type we have in Web. Added the change to Example App too :) |
@Karthik-B-06 ok that makes sense. Looks good. Did you run the example to check it still works? I can't run it right now because I'm away for the holidays. Looks good to me though. Thanks again for contributing :). If you can just confirm the radio example works on the example app I'm happy to merge it. |
Hey @dannyhw I will get back after checking if the radio control type works on the example app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested the example its looking good, thanks for your contribution 🙏 .
Sorry it took so long I've been away for the Christmas break.
changed 'radios' to 'radio'
Issue: Fixing issue #308
What I did
Changed the radio control to work with both Mobile and Web by changing the ControlType string of
radios
toradio
.How to test
Please explain how to test your changes and consider the following questions
No, since the original docs of the storybook include the key with 'radio'
No, the changes are accommodated in the storybook original docs.
If your answer is yes to any of these, please make sure to include it in your PR.