Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes #253. Improve the message shown on the Controls tab when the story has no controls configured #254

Merged

Conversation

lauriharpf
Copy link
Contributor

Issue: #253

What I did

Improved the message shown on the Controls tab when the story has no controls configured. Here's a screenshot of the new message on iOS & Android:

Screen Shot 2021-08-15 at 18 37 33

How to test

Run the example app under examples/native. Open the first example (Background StoriesOf => Basic) and look at the message shown on the Controls tab.

  • Does this need a new example in examples/native? no, not in my opinion
  • Does this need an update to the documentation? no, not in my opinion

… tab when the story has no controls configured.
@lauriharpf lauriharpf requested a review from dannyhw as a code owner August 15, 2021 15:57
Copy link
Member

@dannyhw dannyhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👍

@dannyhw dannyhw merged commit 2997c3e into storybookjs:next-6.0 Aug 15, 2021
@lauriharpf lauriharpf deleted the fix/improve-controls-tab-message branch August 15, 2021 18:24
dannyhw pushed a commit to raychanks/react-native that referenced this pull request Feb 7, 2022
… tab when the story has no controls configured. (storybookjs#254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants