Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove the need to install util and util-deprecate from the v6README (works without them) #245

Merged

Conversation

lauriharpf
Copy link
Contributor

Issue: #237

What I did.

Confirmed that util and util-deprecate no longer need to be added as dependencies with alpha.1, so removed those from the v6README. Note: https://gist.github.com/dannyhw/9b84973dcc6ff4fa2e86e32d571d294e should also be edited accordingly.

How to test

Repeat the steps in the v6README and confirm that the project works.

@lauriharpf lauriharpf requested a review from dannyhw as a code owner July 27, 2021 22:00
Copy link
Member

@dannyhw dannyhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@dannyhw dannyhw merged commit bf76e81 into storybookjs:next-6.0 Jul 28, 2021
@dannyhw
Copy link
Member

dannyhw commented Jul 28, 2021

gist was also updated

@lauriharpf lauriharpf deleted the docs/remove-util-dependencies-from-v6 branch July 28, 2021 13:27
dannyhw pushed a commit to raychanks/react-native that referenced this pull request Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants