fix: Fixes selected story changing when editing the story file #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Run the React Native examples (under examples/native) 2. Select a story, e.g. "Boolean control - Basic" (Boolean.stories.tsx) 3. Edit that story file (e.g. change the "on" argument to false in Boolean.stories.tsx) ## What happened before this fix The entire app reloaded and the currently selected story was changed. ## What happens now after the fix The entire app reloads, but the selected story persists. This improves the developer UX (don't need to always re-select the story after changes).
dannyhw
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #219
What I did
Fixed issue that could be repeated with the following steps:
What happened before this fix
The entire app reloaded and the currently selected story was changed. See video below:
125520359-da2fe881-c503-47b5-b78b-04152ad990aa.mov
What happens now after the fix
The entire app reloads, but the selected story persists. This improves the developer UX (don't need to always re-select the story after changes).
fixed-branch.mov
Unlike PR #222 this also works with stories that are in
storiesOfformat:Screen.Recording.2021-07-14.at.18.41.53.mov
How to test
See example steps under "What I did".
If your answer is yes to any of these, please make sure to include it in your PR.