Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add array control type #221

Merged
merged 2 commits into from
Jul 14, 2021
Merged

feat: add array control type #221

merged 2 commits into from
Jul 14, 2021

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Jul 13, 2021

Issue: #199

What I did

I added the Array control type and an associated example

How to test

Run the example and open the array story

@dannyhw dannyhw added the 6.5 label Jul 13, 2021
@dannyhw dannyhw added this to the v6 alpha 1 milestone Jul 13, 2021
@dannyhw dannyhw self-assigned this Jul 13, 2021
@dannyhw
Copy link
Member Author

dannyhw commented Jul 13, 2021

@lauriharpf if you have time could you review these changes?

Copy link
Contributor

@lauriharpf lauriharpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice & works well on both platforms 👍 🚀 🥇 !

Just a couple of very minor comments, nothing that blocks this IMO.

@dannyhw dannyhw merged commit 0fd9237 into next-6.0 Jul 14, 2021
@dannyhw dannyhw deleted the feat/array-control branch February 2, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants