fix: Fixes #211 (After opening the keyboard the android UI shrinks) #218
Conversation
… shrinks). The steps to reproduce this issue on the Android emulator were: 0. Run the React Native examples (under examples/native) on Android 1. Open the story Navigator. 2. Select the "Basic" story. 3. Open "Addons -> Controls" 4. Click on the "first" field so that the keyboard comes up. 5. Click back to "Navigator" ## What happened The story list in the navigator gets truncated a lot (seems to only occupy ~50% or so of the screen) after Step 5. ## What happens now after the fix The story list doesn't get truncated; it looks the same it did after Step 1.
|
How does this behave when using an input in the preview (as part of a story)? Thanks again for your contribution :) |
| @@ -459,7 +459,7 @@ SPEC CHECKSUMS: | |||
| CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99 | |||
| DoubleConversion: cf9b38bf0b2d048436d9a82ad2abe1404f11e7de | |||
| FBLazyVector: 7b423f9e248eae65987838148c36eec1dbfe0b53 | |||
| FBReactNativeSpec: 60baaee9d10a9d225389062decbbf2b0bd6420ce | |||
| FBReactNativeSpec: ba3bc03e12cb0bea22d69a8a9458eaf3e92521a8 | |||
There was a problem hiding this comment.
there is a bug with react native 64.1 where this hash is different on every machine, it's probably better not to commit these changes for now (FBReactNativeSpec). Maybe we should add the podfile lock to the ignore?
There was a problem hiding this comment.
Since this isn't really a blocker I merged anyway.
There was a problem hiding this comment.
Thanks for the heads-up, wasn't aware of this! 👍
I've been under the impression that version controlling Podfile.lock is a good idea (https://stackoverflow.com/questions/44028199/why-should-you-include-podfile-lock-under-version-control), but not sure how important it is in a React Native project 🤔 .
In any case, definitely no reason to commit the FBReactNativeSpec hash changes if it always changes from machine to machine at the moment - will keep that in mind!
Duh, you mentioned that in the issue description but I totally forgot. Sorry! Glad to hear it worked for you. I could still make another PR that contains a story with a |
@lauriharpf I tried it out and it seems fine to me. I could commit the input example I already made though |
Sounds great, please do! 👍 🥇 |
Issue: #211
What I did
Removed
How to test
The steps to reproduce this issue on the Android emulator were:
What happened
The story list in the navigator gets truncated a lot (seems to only occupy ~50% or so of the screen) after Step 5.
What happens now after the fix
The story list doesn't get truncated; it looks the same it did after Step 1.
Other
The code this PR removes was introduced in e413ec2 . While testing (both on Android and iOS), I didn't notice any issues caused by removing this code. It is of course possible that there is a case that I've missed, but the code this PR removes clearly causes an issue in a common use case.
UX with this branch
with_fix.mov
UX in the next-6.0 branch (=without this fix)
before_fix.mov