refactor: Refactors Addons.tsx to a function component #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lauriharpf thanks for your contribution 🙏 I will review it as soon as possible. |
lauriharpf
force-pushed
the
refactor/addons-to-function-component
branch
from
8fd5667 to
3d611b6
Compare
dannyhw
approved these changes
Jun 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #179
What I did
Refactored app/react-native/src/preview/components/OnDeviceUI/addons/Addons.tsx to a function component as planned
How to test
Was unable to run the examples on Android and iOS, both with and without these changes. Opened #186 with details.Run the native examples and check that the Addons tab renders correctly