Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.0] an action appears in the controls tab as an invalid control type #242

Closed
dannyhw opened this issue Jul 22, 2021 · 0 comments
Closed

[6.0] an action appears in the controls tab as an invalid control type #242

dannyhw opened this issue Jul 22, 2021 · 0 comments
Assignees
@lauriharpf
Labels
6.5 bug Something isn't working

Comments

@dannyhw
Copy link
Member

dannyhw commented Jul 22, 2021

Describe the bug

When I specify the argType is an action then when navigating to the controls tab it shows an invalid type for the control.

To Reproduce

Steps to reproduce the behavior:

  1. In example app go to the action example story
  2. open addons tab and navigate to controls tab

Expected behavior

An action shouldn't appear as a control since it's not something that you adjust.
@dannyhw dannyhw added bug Something isn't working 6.5 labels Jul 22, 2021
@dannyhw dannyhw added this to the v6 alpha 2 milestone Jul 22, 2021
@lauriharpf lauriharpf self-assigned this Jul 28, 2021
lauriharpf added a commit to lauriharpf/react-native that referenced this issue Jul 28, 2021
@lauriharpf
fix: Fixes storybookjs#242 (an action appears in the controls tab as …
12de09a 
…an invalid control type).

In the controls panel, filter out the non-control args so that e.g. actions do not incorrectly get shown in the controls tab.
@lauriharpf lauriharpf mentioned this issue Jul 28, 2021
Merged
dannyhw pushed a commit to raychanks/react-native that referenced this issue Feb 7, 2022
@lauriharpf
fix: storybookjs#242 an action appears in the controls tab as an inva…
4ccb373 
…lid control type (storybookjs#246)

In the controls panel, filter out the non-control args so that e.g. actions do not incorrectly get shown in the controls tab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lauriharpf lauriharpf

Labels
6.5 bug Something isn't working
Projects
React Native Storybook
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dannyhw @lauriharpf