Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mdx import out of loader into compile #20

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Feb 13, 2023

Issue: N/A

To simplify the vite implementation of MDX1 per storybookjs/storybook#20823

What Changed

How to test

See attached tests

Change Type

  • maintenance
  • documentation
  • patch
  • minor
  • major
📦 Published PR as canary version: 0.0.5--canary.20.d7a3376.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

Version

Published prerelease version: v1.0.0-next.1

Changelog

💥 Breaking Change

🐛 Bug Fix

Authors: 2

To simplify the vite implementation of MDX1
@shilman shilman added the enhancement New feature or request label Feb 13, 2023
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically a breaking-change, I think, but we're still in pre-releases for 1.0.0, so I think this is good to go. It will simplify usage of mdx1-csf for non-webpack builders.

@shilman shilman merged commit f408fc9 into next Feb 13, 2023
@shilman shilman deleted the shilman/move-mdx-import-from-loader branch February 13, 2023 15:48
@github-actions github-actions bot mentioned this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants