Support skipCsf option in compile functions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwooding
commented
May 14, 2022
src/index.ts
Outdated
| @@ -2,9 +2,9 @@ import mdx from '@mdx-js/mdx'; | |||
| import { createCompiler, MdxOptions } from './sb-mdx-plugin'; | |||
|
|
|||
| export const compile = async (code: string, options?: MdxOptions) => | |||
| mdx(code, { compilers: [createCompiler(options)] }); | |||
| mdx(code, { compilers: options.skipCsf ? [] : [createCompiler(options)] }); | |||
There was a problem hiding this comment.
Technically skipCsf will be passed to createCompiler but these options are ignored anyway
joshwooding
force-pushed
the
support-skipcsf-compile
branch
from
8161d3b to
fa6f535
Compare
|
Was this fixed elsewhere? |
|
@joshwooding it seems like GH automatically closed this PR when I deleted the base branch. Can you re-open if this is still relevant? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #
What Changed
This will allow the vite builder to use the compile function on non-story mdx files.
How to test
Change Type
maintenancedocumentationpatchminormajor