Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SB design system #42

Merged
merged 17 commits into from
Jul 3, 2019
Merged

Use SB design system #42

merged 17 commits into from
Jul 3, 2019

Conversation

domyen
Copy link
Member

@domyen domyen commented May 17, 2019

What I did
Use Storybook's design system for common components

What changed visually
Nothing should have changed visually. This is a swap-in-out job.

Note: I reorganized the component hierarchy so Chromatic is identifying the stories as "new" which requires approval.

@domyen domyen added enhancement New feature or request DO NOT MERGE Don't merge this yet labels May 17, 2019
@kylesuss
Copy link
Collaborator

kylesuss commented Jul 2, 2019

@domyen 1 thing I was unable to get to is consolidating the global styles seen here:

https://github.com/storybookjs/frontpage/blob/design-system/src/components/basics/shared/global.js

I realized as well that I didn't get to this in learnstorybook.com either. Must have just slipped by somehow. Ultimately, there is a problem with the design system loading the fonts this way. The GlobalStyle is re-rendered on each page change, so (1) there is a network request for the font every page change which is bad and (2) there is a flicker of the text that uses the font each time it loads. Therefore, we will have to update the design system to accommodate this quirk.

Leaving the GlobalStyle as-is here for now does not have that same issue.

@domyen
Copy link
Member Author

domyen commented Jul 2, 2019

Thanks for the heads up. Let's skip it for now :D

@kylesuss
Copy link
Collaborator

kylesuss commented Jul 2, 2019

@domyen ticket added: storybookjs/design-system#54

@domyen domyen removed the DO NOT MERGE Don't merge this yet label Jul 3, 2019
@domyen
Copy link
Member Author

domyen commented Jul 3, 2019

QA'ed! This looks good to go.

@domyen domyen merged commit ff97712 into master Jul 3, 2019
@domyen domyen deleted the design-system branch July 3, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants