Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global styling setup to README #79

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Conversation

kylesuss
Copy link
Contributor

All of the client applications that use this design system depend on the global styling that we export, thought it has remained undocumented. This PR adds the instructions on how to use the global styling to the README.

@kylesuss kylesuss requested a review from tmeasday September 26, 2019 15:48
@kylesuss
Copy link
Contributor Author

@tmeasday you have touched this recently in the consumer apps so are probably the most qualified to review, if possible?

https://github.com/storybookjs/design-system/blob/947b4322c8ac672116a27e651398619dec2c146f/README.md#global-styles

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we maybe consider adding a dedicated section to using within Storybook?

README.md Outdated Show resolved Hide resolved
@tmeasday tmeasday assigned kylesuss and unassigned tmeasday Sep 30, 2019
Co-Authored-By: Tom Coleman <[email protected]>
@kylesuss
Copy link
Contributor Author

kylesuss commented Oct 4, 2019

@tmeasday sounds good. Merging this for now & filed a ticket for the enhancement:

#83

@kylesuss kylesuss merged commit 9cb4c78 into master Oct 4, 2019
@kylesuss kylesuss deleted the readme-global-styles branch October 4, 2019 22:50
@kylesuss
Copy link
Contributor Author

kylesuss commented Oct 7, 2019

🚀 PR was released in v1.1.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants