Use focus-visible to hide outlines when using mouse #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylesuss
reviewed
Dec 29, 2020
Comment on lines
-73
to
-79
| &:focus { | ||
| box-shadow: ${rgba(color.primary, 0.4)} 0 1px 9px 2px; | ||
| } | ||
|
|
||
| &:focus:hover { | ||
| box-shadow: ${rgba(color.primary, 0.2)} 0 8px 18px 0px; | ||
| } |
There was a problem hiding this comment.
Doesn't look like you added these styles back anywhere. Do I have that right? Was that the intent?
There was a problem hiding this comment.
That's right. I removed them all because we now have a better way to detect whether something if focused via mouse and via keyboard. If it's via mouse, there's no focus UI. If it's via keyboard, we should use the system default focus UI.
There was a problem hiding this comment.
I see. Cool. Makes sense.
kylesuss
reviewed
Dec 30, 2020
kylesuss
approved these changes
Dec 30, 2020
|
Merge when ready 👍 |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide :focus outlines when using a mouse and remove a bunch of :focus button styles.