Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcode input sizes in pixels #227

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Hardcode input sizes in pixels #227

merged 1 commit into from
Nov 20, 2020

Conversation

domyen
Copy link
Member

@domyen domyen commented Nov 20, 2020

Makes sizing less obscure and prevents style pollution from parent selectors.

@domyen domyen requested a review from kylesuss November 20, 2020 20:14
@domyen domyen added the enhancement New feature or request label Nov 20, 2020
kylesuss
kylesuss approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@kylesuss kylesuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@domyen domyen merged commit 82bfb21 into master Nov 20, 2020
@domyen domyen deleted the form-input-tweaks branch November 20, 2020 20:31
@kylesuss kylesuss added the patch Increment the patch version when merged label Nov 20, 2020
@kylesuss
Copy link
Contributor

🚀 PR was released in v5.2.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylesuss kylesuss kylesuss approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request patch Increment the patch version when merged released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domyen @kylesuss