Input styling changes, Form component addition #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,14 +87,14 @@ export function Tooltip({ | |||
| }) { | |||
| return ( | |||
| <TooltipWrapper hasChrome={hasChrome} data-placement={placement} ref={tooltipRef} {...props}> | |||
| {hasChrome && <Arrow data-placement={placement} ref={arrowRef} {...arrowProps} />} | |||
| <Arrow isVisible={hasChrome} data-placement={placement} ref={arrowRef} {...arrowProps} /> | |||
There was a problem hiding this comment.
Thank you for adding this one!
There was a problem hiding this comment.
No prob -- did you run into this issue as well?
There was a problem hiding this comment.
yea, while adding the search dropdown on the blog
ndelangen
approved these changes
Oct 26, 2020
|
@ghengeveld I reworked this w/ the pattern we discussed on the call today. I think it ends up being more flexible, as you say. LMK what you think. |
ndelangen
reviewed
Oct 27, 2020
ndelangen
approved these changes
Oct 28, 2020
ghengeveld
approved these changes
Nov 18, 2020
|
👏 |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Inputelement has new styling, per the designs here:https://projects.invisionapp.com/d/main#/console/20597416/432876968/preview
In addition to that, I have added a "lightweight"
Formcomponent that does not make any assumptions about how you manage form state (values, onChange, etc.), though it does encode some UX patterns for how we handle error messages & validate form fields. The intent was to make this extremely flexible, but create a set of behaviors that we will want on form across our properties based on the design language. I added some example for how to manage state in the stories, but they are mostly meant for documentation/example purposes.The API is backwards compatible, so I am setting this to a
minorrelease.PS this will be the first design system component I added w/ TypeScript so let me know what I can do to improve that 👍