Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Loading AvatarList Not Showing in Stories #214

Merged
merged 2 commits into from
Oct 20, 2020
Merged

Fix Loading AvatarList Not Showing in Stories #214

merged 2 commits into from
Oct 20, 2020

Conversation

ahmadatallah
Copy link
Contributor

@ahmadatallah ahmadatallah commented Oct 17, 2020 •
edited
Loading

Description

A tiny PR for showing the loading avatar-list example in stories as it was not showing and instead, it displays empty avatar-list.

Checklist

  • Add users and userCount to the loading avatar story.
  • Fix prettier warning for always add parentheses around arrow function (fixed automatically when I run prettier command on the file from my text editor)

kylesuss
kylesuss requested changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@kylesuss kylesuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left a comment about the story args -- let me know what you think.

kylesuss
kylesuss approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@kylesuss kylesuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thanks for this!

@kylesuss kylesuss merged commit 9674dfb into storybookjs:master Oct 20, 2020
@kylesuss
Copy link
Contributor

🚀 PR was released in v5.2.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylesuss kylesuss kylesuss approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmadatallah @kylesuss