includes className prop on tooltip/TooltipMessage component #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also includes an example of how to mod the component using styled components.
kylesuss
requested changes
Oct 9, 2020
There was a problem hiding this comment.
Hey @D3Portillo , I may have misspoken slightly. I just noticed this commit:
99442cc
I think perhaps this may have been added and the original issue wasn't closed. That said, I think the story that you added here is valuable. Can you do me a favor? Try removing your changes in TooltipMessage.js and see if your story still renders the same. I suspect it will because we are passing down ...rest to the MessageWrapper. That's typically the pattern we follow.
Would love to merge your story in once you confirm!
🙇
|
Will do, no problem : ) |
|
Yes it renders as expected. I tough you needed a prop validation or the |
This commit includes the delition of previus commit modding TooltipMEssage, this also includes an story for theming up the component
kylesuss
approved these changes
Oct 9, 2020
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also includes an example of how to mod component using styled components.