Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: button icon only demo text alternative #17

Merged
merged 1 commit into from
Jun 15, 2019

Conversation

jsomsanith-tlnd
Copy link
Contributor

What is the problem this PR is trying to solve?
Button story has an icon-only button, without text alternative.

What is the chosen solution to this problem?
Fix the story, adding an aria-label to the icon-only button.

@domyen domyen merged commit b5462ef into master Jun 15, 2019
@domyen domyen deleted the jsomsanith/chore/button_demo_a11y branch June 15, 2019 16:28
@kylesuss
Copy link
Contributor

🚀 PR was released in v0.0.23 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants