Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 6.0 / Args #164

Merged
merged 12 commits into from
Jun 3, 2020
Merged

Upgrade to 6.0 / Args #164

merged 12 commits into from
Jun 3, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 21, 2020

What I did

design-system-args

  • Upgrade to 6.0
  • Add a Basic story to all components to showcase SB Args
  • Simplify story naming convention
  • Capitalize story names per SB recommendations
  • Remove addon-deps temporarily until we can figure out 6.0/args compat
  • Filed issues on SB with Args/Props bugs (see below)

Still to do

  • Open issues
    • Props: Boolean controls always initialize to true #10497
    • Props: Controls for React children crashes Storybook #10498'
    • Props: Controls for Array of objects broken #10499
  • Merge after Args stabilization + design system maintainer approval

@tmeasday
Copy link
Member

TODO: rewrite all stories in terms of args ;)

.storybook/preview.js Outdated Show resolved Hide resolved
@kylesuss
Copy link
Contributor

kylesuss commented Apr 21, 2020

@shilman Looks great 👏

I just realized I don't really know the finer details of how this is supposed to work! Are there any docs or anything I can read to understand how args are meant to work?

Thanks for taking the time to do this.

@shilman
Copy link
Member Author

shilman commented Apr 22, 2020

Thanks @kylesuss ! Docs are still WIP, but here are some resources to help get a sense of what's going on.

Questions/suggestions/contributions welcome to make this better on both the code and documentation!

@kylesuss
Copy link
Contributor

Thanks @shilman . Sorry I have been a bit distracted trying to wrap some QA. Will take a look at this next week!

@shilman
Copy link
Member Author

shilman commented Apr 24, 2020

@kylesuss no rush at all. There are still underlying bugs to fix in Storybook before this can even be considered for merge. I only put the PR up to get the ball rolling. Godspeed on the QA!

@kylesuss
Copy link
Contributor

kylesuss commented May 5, 2020

@shilman Aside from the comments I made re: documenting args, this is looking great! Ping me when you need a final review 👌

@ndelangen
Copy link
Member

Is this ready?

@shilman
Copy link
Member Author

shilman commented May 12, 2020

Ready? Not sure but we can merge and iterate if it’s blocking your stuff

@ndelangen
Copy link
Member

not blocking anything on my part

Just wanted to make some progress.

@kylesuss
Copy link
Contributor

@shilman @ndelangen is this done now?

@ndelangen
Copy link
Member

I dunno @shilman ?

@ndelangen ndelangen merged commit fee63b2 into master Jun 3, 2020
@ndelangen ndelangen deleted the upgrade-to-args branch June 3, 2020 12:37
@ndelangen
Copy link
Member

🚀 PR was released in v5.1.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request minor Increment the minor version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants