Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle resolve.alias as an array #430

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Jul 7, 2022

Fixes #425.

We weren't being smart enough about merging in the resolve.alias config, which can either be an object or an array. So, I've used mergeConfig from vite to handle that instead, and added a demonstration in the vue example that fails without this change but works with it.

@rlesniak, how's this look to you?

@IanVS IanVS requested a review from joshwooding July 7, 2022 03:39
@IanVS IanVS merged commit 61170d7 into main Jul 7, 2022
@IanVS IanVS deleted the issue/425-resolve-alias-array branch July 7, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Regression with resolve.alias as array
2 participants