Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to @storybook/builder-vite #293

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Rename to @storybook/builder-vite #293

merged 2 commits into from
Mar 30, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 30, 2022

What I did

  • Rename storybook-builder-vite to @storybook/builder-vite
  • Rename package folder

How to test

  • CI passes

@IanVS
Copy link
Member

IanVS commented Mar 30, 2022

After this is done, we'll want to deprecate the old name in npm and point to the new one. https://docs.npmjs.com/cli/v8/commands/npm-deprecate.

As for the lint warning, sorry about that. The contributor who set up the eslint config wanted it so that it showed a vertical line in his IDE, but personally I'd be happy to remove that rule from the eslint config. I thought prettier would have taken care of them all to avoid eslint errors, not sure why this one didn't.

@shilman
Copy link
Member Author

shilman commented Mar 30, 2022

@IanVS thanks! i'm going to make a few changes in storybook as well:

@shilman shilman changed the title Rename storybook-builder-vite to @storybook/builder-vite Rename to @storybook/builder-vite Mar 30, 2022
@IanVS IanVS requested review from joshwooding and eirslett March 30, 2022 15:27
@IanVS
Copy link
Member

IanVS commented Mar 30, 2022

Might be worth updating https://storybook.js.org/blog/storybook-for-vite/ as well?

@shilman
Copy link
Member Author

shilman commented Mar 30, 2022

@IanVS Definitely, will fix that once everything else is set up. We're also adding this to the official docs soon.

@shilman shilman merged commit 04885f0 into main Mar 30, 2022
@shilman shilman deleted the move-to-storybook-org branch March 30, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants