Fix: svelte #240
Fix: svelte #240
Conversation
|
Thanks for this PR, @bfanger! It looks like our check might need to be updated too?
|
|
Ah, I missed adding a file in last commit. the locally compiled version of storybook-builder-vite already contained the change. Not sure why CI fails on |
There was a problem hiding this comment.
Thanks for working on this! When running packages/example-svelte, I'm seeing this error in the browser console.
ClientApi.js:85 Uncaught Error: Singleton client API not yet initialized, cannot call `addArgTypesEnhancer`.
Any idea why that might be?
Also, I needed to add @storybook/svelte to the list in optimizeDeps.ts. Would you mind doing that here as well?
| // const __storiesMetaData = parser(${componentName}, ${JSON.stringify(storiesDef)}); | ||
| // export default __storiesMetaData.meta; | ||
| // ${storyDef}; | ||
| // `); |
There was a problem hiding this comment.
Just curious, why is this commented out?
There was a problem hiding this comment.
I've removed the comment, (I copied it from @storybook/addon-svelte-csf for reference, but in contrary to the error message, the export was not the issue.)
|
Uncaught Error: Singleton client API not yet initialized, cannot call After a to fix that issue. I think that's a bug in yarn, it should dedupe that dependency. |
TypeError: RegisterContext is not a constructorerror. (Svelte compiler was in 'ssr' mode)Fixes #224
(Also implemented support for preprocessors inside *.stories.svelte files)