Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use updated babel preset package name in react native 73. #78

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

joarkosberg
Copy link
Contributor

Background

React native 73 renamed the babel packages, which makes this addon not work with react native 73, as this package uses the old babel package name.

Changes

  • Update to use updated babel preset package name in react native 73.
    • Will then support react native 73, but not older versions.
  • Removed babel plugin plugin-proposal-class-properties, as react native already defines this
  • Added babel dependency plugin-proposal-export-namespace-from, as it is not provided anymore.
  • Updated dev react-native to 73 (including removing types which are part of react native now)
  • Update README with new package name.

* Will then support react native 73, but not older versions.
@dannyhw
Copy link
Member

dannyhw commented Jan 4, 2024

thanks so much for this contribution 🙏

@dannyhw
Copy link
Member

dannyhw commented Jan 4, 2024

heres the storybook link for this branch https://618d44792e48fd003a482f88-wmaqsnknaj.chromatic.com/

Copy link
Member

@dannyhw dannyhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works great, thanks!

@dannyhw
Copy link
Member

dannyhw commented Jan 4, 2024

I think we could add some backwards compatibility here to toggle if we use the old or the new package name (another option maybe). I'll think of something for that then merge once I test that solution.

@joarkosberg
Copy link
Contributor Author

I think we could add some backwards compatibility here to toggle if we use the old or the new package name (another option maybe). I'll think of something for that then merge once I test that solution.

Sounds great 😊

@dannyhw
Copy link
Member

dannyhw commented Jan 7, 2024

just updated this so that it trys to use the new one if its installed and falls back to the old one if thats installed instead.

@dannyhw dannyhw merged commit bb48857 into storybookjs:main Jan 7, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants