Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unexpected token '.' on project root #18

Merged
merged 2 commits into from
Nov 25, 2021
Merged

fix: unexpected token '.' on project root #18

merged 2 commits into from
Nov 25, 2021

Conversation

lacsinagramar
Copy link
Contributor

Fix for this syntax error:

image

@lacsinagramar lacsinagramar mentioned this pull request Nov 25, 2021
Closed
@dannyhw
Copy link
Member

dannyhw commented Nov 25, 2021

@lacsinagramar thanks for your contribution 🙇 .

I'll try and test it out later today.

@dannyhw dannyhw linked an issue Nov 25, 2021 that may be closed by this pull request
Some modules are not rendered on storybook, but rn-webapp can render it #14
Closed
dannyhw
dannyhw approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@dannyhw dannyhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

FYI I applied some prettier auto fixes.

@dannyhw dannyhw merged commit c8693a7 into storybookjs:main Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyhw dannyhw dannyhw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some modules are not rendered on storybook, but rn-webapp can render it
2 participants
@lacsinagramar @dannyhw