Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Modal improvements #22

Merged
merged 5 commits into from
Jun 5, 2023
Merged

Modal improvements #22

merged 5 commits into from
Jun 5, 2023

Conversation

cdedreuille
Copy link
Collaborator

@cdedreuille cdedreuille commented Jun 5, 2023 •
edited by valentinpalkovic
Loading

Closes #23

In this PR I'm focusing on improving elements for the Modal component only including:

  • Add a height property to fix the height of the modal the same way we do for width.
  • Add a default width to make sure it never goes full screen on desktop.
  • Added missing stories and controls.
  • Removed styling and props for Title and Description. I don't believe we need those for this component.
  • Move the styling of the Title + Description to the WelcomeModal
  • Unified how we call Radix across the component and styles
📦 Published PR as canary version: 0.0.14--canary.22.27381c8.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@cdedreuille cdedreuille added the patch Increment the patch version when merged label Jun 5, 2023
@cdedreuille cdedreuille removed the request for review from yannbf June 5, 2023 13:38
@valentinpalkovic valentinpalkovic merged commit 51234e3 into main Jun 5, 2023
@valentinpalkovic valentinpalkovic deleted the modal-improvements branch June 5, 2023 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@valentinpalkovic valentinpalkovic valentinpalkovic approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Project - Onboarding]: Style Modal component
2 participants
@cdedreuille @valentinpalkovic