Collapse / Expand not working

[mnboos]

Hi alexcurtis
I've the the same problem as in issue #27
The tree is shown correctly on initial render but clicking nodes does nothing - can't expand/collapse, active node not highlighted.

[sonuj]

expand and collapse of parent node is not working

[emilyfeder]

I think it's because React is not registering it as a state change and is not calling render() again.
Also, I think ideally onToggle should switch the node toggled state internally inside the Treebeard Component instead of you having to manually do it each time.
Try the following instead (I haven't actually tested this, as a fair warning):

class TreeExample extends React.Component {
	constructor(props){
		super(props);
		this.state = {
			data: props.data
		};
		this.onToggle = this.onToggle.bind(this);
	}
	onToggle(node, toggled){
		if(this.state.cursor){this.state.cursor.active = false;}
		node.active = true;
		let new_data = this.state.data;
		if(node.children){
			node.toggled = toggled;
			new_data = Object.assign({}, this.state.data);
		}
		this.setState({ cursor: node, data: new_data });
	}
	render(){
		return (
			<Treebeard
				data={this.state.data}
				onToggle={this.onToggle}
			/>
		);
	}
}

[skohub]

Possibly you have put

const data = {
    name: 'root',
    ...
}

inside render method, so the data is being rewritten from scratch on every click.

[Waize]

There is an issue with the animations.
If you turn them off:
<Treebeard data={data} onToggle={this.onToggle} animation={false}/>
It works fine.
Maybe @MichaelDeBoey needs to double check the animation conditions in renderDrawer from node.js

[Waize]

#111

[Waize]

@maximilianoforlenza with #174 this issue is worse than before:
with this workaround here (animation == false) it will not toggle at all, although working fine before
removing animations-flag will still not bring animations back.

[Waize]

@maximilianoforlenza any news on this?

[maximilianoforlenza]

No yet. I'll working on this today.

[maximilianoforlenza]

@Waize please try this https://codesandbox.io/s/7jkkj5vkn1 (#209)

[Waize]

Woah ... I missed that you did a breaking change with forcing react >= 16.7.0.  We are currently on 16.3.2. Please keep in mind to announce this kind of changes and don't hide them in a "update some dependencies" message. Is there any chance to got this chrome v74 fix in an 2.1.1 Version? ⁣Regards, Waize Am 10. Mai 2019, 19:26, um 19:26, Maximiliano Raul Forlenza <[email protected]> schrieb:

…

@Waize please try this #209 -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #58 (comment)

[maximilianoforlenza]

No, you should fork the project, back to version 2.1.1 fix it and use the forked version.

[maximilianoforlenza]

If it's working https://codesandbox.io/s/7jkkj5vkn1 I close this issue @Waize