Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: missing Astro component type declarations #454

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

manuelschroederdev
Copy link
Contributor

This PR fixes #352, introducing a new components folder and optimizing the package.json.
Additional improvements:

  • dependencies updated
  • tsconfig.json optimized to account for temporary Cypress issue
  • module.d.ts for Vite virtual modules added

// Old "moduleResolution": "Node" option required for Cypress
// https://github.com/cypress-io/cypress/issues/26308#issuecomment-1663592648
// TODO: Remove when issue is resolved https://github.com/cypress-io/cypress/issues/27448
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point to add this comment

@manuelschroederdev manuelschroederdev merged commit 72563f2 into main Sep 20, 2023
@github-actions
Copy link

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Dec 4, 2023

🎉 This PR is included in version 3.1.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing StoryblokComponent.astro type declarations
3 participants