-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: making livepreview stable #1061
Open
dipankarmaikap
wants to merge
9
commits into
main
Choose a base branch
from
feat/livepreview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`useStoryblok` function has been removed. Please refer to the updated documentation.
A new event triggers when changes are made in the Storyblok Visual Editor. Closes #864.
dipankarmaikap
requested review from
alexjoverm,
alvarosabu and
manuelschroederdev
and removed request for
alvarosabu
January 17, 2025 09:00
alexjoverm
approved these changes
Jan 17, 2025
alexjoverm
requested review from
alvarosabu
and removed request for
manuelschroederdev
January 17, 2025 11:17
alvarosabu
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking the merge while doing the QG
alvarosabu
approved these changes
Jan 24, 2025
@dipankarmaikap QG passed, you can merge, great job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stabilizes the experimental Live Preview feature and introduces breaking changes. The
useStoryblok
hook is now removed. Below are the key updates and usage examples.Breaking Changes
Removal of
useStoryblok
:The
useStoryblok
hook has been removed in favor ofgetLiveStory
. This function simplifies the implementation of live preview in your Astro application.Named Export for
storyblok
:The
storyblok
initialization is now exported as a named export instead of a default export. Update yourastro.config.mjs
imports accordingly.Usage Example
Configure Storyblok in
astro.config.mjs
using the named export:Page Example
Here’s how you can use
getLiveStory
in a page:Listening for Live Preview Updates
When the live preview updates content in the Storyblok editor, a custom event (
storyblok-live-preview-updated
) is triggered. Applications can listen for this event as follows:Closing Issues
This PR addresses and closes the following issue(s):
loadStoryblokBridge
is injected twice #943