feat(lib): add event listener for ESC key handler #404
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Working on the unit tests right now, but would love to have some review of the approach also @BibiSebi @eunjae-lee @demetriusfeijoo 💜 |
|
I wonder if this will affect the existing plugins (once they upgrade the field plugin library version) |
The idea was to update one of ours to try out after this PR is merged, but in my mind, that's actually what I tried to do putting it in the lib and not in the templates, I did right then? |
packages/field-plugin/src/createFieldPlugin/createPluginActions/createPluginActions.ts
Show resolved
Hide resolved
|
just realized that Alba is not included as a contributor :) @all-contributors please add @Dawntraoz for code. |
|
I've put up a pull request to add @Dawntraoz! 🎉 |
How cool is that bot 🤩 I didn't know it exists, you just made my day @eunjae-lee |
|
@Dawntraoz already contributed before to code |
What?
Whenever a modal is opened inside a custom field plugin, it is impossible to close the modal on escape. This keyboard listener fixes that issue inside and outside the iframe by changing the isModalOpen state and notifying the container.
Why?
JIRA: SHAPE-2151
This is important for people who use a keyboard only to navigate.
How to test? (optional)