fix(lib): make the translatable property optional #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eunjae-lee
approved these changes
Mar 8, 2024
eunjae-lee
deleted the
EXT-2267-fix-field-plugin-not-being-loaded-in-the-field-plugin-editor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It makes the
translatableproperty optional in the plugin'sschema.Why?
JIRA: EXT-2267
The
translatableproperty is not always present and we were expecting it to be.So, for example, in the Field Plugin Editor (where this property doesn't exist in the schema), the field plugin was breaking because the schema validation just failed due to the lack of this property.