feat(sandbox): add checkbox for translatable property #361
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| }) | ||
| const [content, setContent] = useState<unknown>(initialContent) | ||
| const [language, setLanguage] = useState<string>('') | ||
| const [language, setLanguage] = useState<string>('default') |
There was a problem hiding this comment.
inside storyfront I noticed that the default language seems to be set to 'default'
| const [stateChangedCallbackId, setStateChangedCallbackId] = useState<string>() | ||
|
|
||
| const stateChangedData = useMemo<StateChangedMessage>( | ||
| () => ({ | ||
| model: content, | ||
| schema: schema, | ||
| interfaceLanguage: 'en', |
There was a problem hiding this comment.
This was added due to type issues of StateChangedMessage which forced me to add this line of code.
BibiSebi
force-pushed
the
EXT-2240-update-sandbox
branch
from
d500c26 to
104d6b6
Compare
|
I just realized that this PR should not have been stacked. We will need to release a new version of field-plugin library and then redeploy the sandbox. |
There was a problem hiding this comment.
Looks good to me! If you want to merge this later, then I think you could merge #360 first, and run gt restack on this branch to rebase on the updated main branch. What do you think?
BibiSebi
force-pushed
the
EXT-2240-update-sandbox
branch
from
104d6b6 to
8b83b41
Compare
demetriusfeijoo
force-pushed
the
EXT-2240-update-sandbox
branch
from
8d28e4c to
8b83b41
Compare
|
@BibiSebi anything else you need me to review about this PR? :) |
|
@eunjae-lee no, this is just blocked by the field plugin release which is blocked by the storyfront release :D |
What?
Added new checkbox 'Translatable' to easily develop by being able to turn on and off the functionality. This PR includes the following changes:
translatablepropertyOptionstitle of a section toSettingstranslatableandstoryLanginside the code blockWhy?
JIRA: EXT-2240