fix(helper): test setup mimics sandbox environment #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused test commands from root
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BibiSebi
commented
Jan 23, 2024
There was a problem hiding this comment.
I also tried changing the location to the sandbox url inside the location stub but sadly I could not make it work.
vi.stubGlobal('location', {
...window.location,
search: `?protocol=https%3A&host=plugin-sandbox.storyblok.com&uid=test-uid&preview=1`,
})
There was a problem hiding this comment.
yeah the current update seems good :)
eunjae-lee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR resolves CI breaking after PR #333 was merged. This error occurred because the origin inside the vitest environment was 'localhost' which is currently not permitted.
Why?
JIRA: EXT-2188
How to test? (optional)
yarn test:reactandyarn test:vue3