Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): publish field types on deploys #322

Conversation

demetriusfeijoo
Copy link
Contributor

@demetriusfeijoo demetriusfeijoo commented Nov 30, 2023

What?

This PR enhances our CLI deployment process to always publish the field type whenever a new or existing field type is deployed.

Why?

JIRA: EXT-2074

Currently, all the field types deployed using our CLI are being saved but not published.
As we don't see a use case for this scenario, we're changing this behavior to always publish field-types for new deploys or updates.

I did some tests locally after the adjustments and checked how the data was stored and everything worked as expected.

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plugin-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 2:13pm

@demetriusfeijoo demetriusfeijoo marked this pull request as ready for review December 1, 2023 02:58
Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice! Thanks for the fix :)

@demetriusfeijoo demetriusfeijoo merged commit 90c357e into main Dec 1, 2023
18 checks passed
@demetriusfeijoo demetriusfeijoo deleted the EXT-2074-cli-deploy-publish-field-plugin-on-create-and-update-per-default branch December 1, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants