Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): fix js template #277

Merged

Conversation

eunjae-lee
Copy link
Contributor

What?

This PR fixes the JS template to pass the correct parameter to createFieldPlugin(). Last time we changed createFieldPlugin and forgot to update this template.

Why?

JIRA: EXT-2003

How to test? (optional)

@vercel
Copy link

vercel bot commented Sep 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plugin-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2023 7:24am

@eunjae-lee eunjae-lee requested review from a team and BibiSebi and removed request for a team September 21, 2023 14:22
Copy link
Contributor

@BibiSebi BibiSebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good 🥨

@BibiSebi BibiSebi enabled auto-merge (squash) September 25, 2023 07:07
@BibiSebi BibiSebi merged commit 46ef2e9 into main Sep 25, 2023
@BibiSebi BibiSebi deleted the EXT-2003-fix-our-js-template-for-providing-a-parse-content branch September 25, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants