fix(helper): update vue 2 template and helper

[eunjae-lee]

What?

This PR updates the vue 2 template. Vue 2 helper + template used to have provider / inject pattern, and now that we've removed it, there is no such thing as useFieldPlugin in the vue 2 helper and the template. So what if we just remove vue 2 helper at all? We just need a little bit of snippet in the vue 2 template, and we're not actively supporting vue 2 anyway.

Why?

JIRA: EXT-1958

How to test? (optional)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
plugin-sandbox	❌ Failed (Inspect)			Sep 14, 2023 3:04pm

[eunjae-lee]

Current dependencies on/for this PR:

• main
  • PR feat(common): new subscription model #260
    • PR feat(lib): add parseContent #266
      • PR fix(helper): update react helper #267
        • PR fix(helper): update vue3 helper #269
          • PR fix(helper): update vue 2 template and helper #270 👈
            • PR fix(demo): provide parseContent #271

This comment was auto-generated by Graphite.

[demetriusfeijoo]

@eunjae-lee, I think removing all the vue2 helper would not be bad, IMO.

However, how should we handle the FieldPlugin file?

I think we could remove this file since it seems not to be used anyway. what do you think?

[eunjae-lee]

@demetriusfeijoo if we get rid of vue 2 helper, then we should actually delete this folder, but I didn't yet because we haven't decided yet.

And actually that empty FieldPlugin.vue file is a placeholder for users. We provide an example inside the template, but users can delete the whole example and start from scratch with the FieldPlugin.vue file (which is bare minimum)

[demetriusfeijoo]

And actually that empty FieldPlugin.vue file is a placeholder for users. We provide an example inside the template, but users can delete the whole example and start from scratch with the FieldPlugin.vue file (which is bare minimum)

Oh, I see @eunjae-lee.

I think once we stop using the FieldPluginProvider inside the template, we can remove also the helper, for sure.
This way we avoid some developers using it and blocking us from removing it easily in the future?!

I mean, I was checking here, and after removing the FieldPluginProvider we would have anything else to offer from the helper, right? As we're not going to support this version, maybe the best way would be to remove the helper, indeed.

I was taking a better look at how the new approach would look and I started asking myself on how to make the logic below reusable between both FieldExample/index.vue and FieldPlugin.vue files.

Do you have any idea here? As we don't have hooks here (for useFieldPlugin()), may we use Vue mixins?!
What do you think @eunjae-lee?

[eunjae-lee]

Do you have any idea here? As we don't have hooks here (for useFieldPlugin()), may we use Vue mixins?! What do you think @eunjae-lee?

@demetriusfeijoo hey, thanks for pointing this out. I forgot about this part. added 61be914

[demetriusfeijoo]

Hey @eunjae-lee, thanks for the adjustment. 🙌

What about getting rid of the helper? Do you have a better position on that?

[eunjae-lee]

I've also replaced copy-helpers.sh with copy-helpers.mjs which seems easier to maintain.

[demetriusfeijoo]

It looks good to me @eunjae-lee.

Thanks for you effort on this 🙌

[eunjae-lee]

Merge Activity

• Sep 14, 10:27 AM: @eunjae-lee started a stack merge that includes this pull request via Graphite.
• Sep 14, 10:28 AM: Graphite failed to merge this pull request due to internal failures. Try your merge again, or report a bug if you see this consistently.
• Sep 14, 10:39 AM: @eunjae-lee started a stack merge that includes this pull request via Graphite.
• Sep 14, 10:39 AM: Graphite couldn't merge this pull request because a downstack PR fix(helper): update vue3 helper #269 failed to merge.