feat(lib): handle callbackId in contextRequest
#261
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -2,7 +2,6 @@ import { createPluginActions } from './createPluginActions' | |||
| import { | |||
| AssetModalChangeMessage, | |||
| GetContextMessage, | |||
| HeightChangeMessage, | |||
There was a problem hiding this comment.
This import was not being used
|
I read it briefly, and it looks good! Any doubt or question? |
|
Thanks @eunjae-lee. I was more concerned about being in the right direction with this task @eunjae-lee. |
demetriusfeijoo
changed the title
demetriusfeijoo
changed the title
callbackId in contextRequest
|
Hi Demetrius, Let's pause this task. Johannes is bringing a big change around this: #260 We need more work on the Storyfront side to enable this change on the SDK side, but I'm very happy if we get this. Sorry that this PR probably is going to be closed (because it conflicts with #260), but I hope it was a good practice for you. My PR #253 also will be overridden by this, but we're moving very fast at this point, and it was a bit expected. |
|
Hey @eunjae-lee, pausing/closing this task will not be a problem. This task helped me understand more about how the library works, so enough reward I'd say. It was really cool working on it. 🚀 |
|
closing this PR in favor of #260 |
What?
Modify the requestContext action to return a Promise in place of returning nothing.
Why?
JIRA: EXT-1920
The corresponding pull request in Storyfront is a prerequisite: https://github.com/storyblok/storyfront/pull/4368
This PR has the same purpose (and approach) as this one but is now for the
getContextaction (notselectAsset)Usage implementation:
Result:
How to test? (optional)
This function can be tested using our Sandbox application as described in or [CONTRIBUTING.md →]