chore(cli): change helper folder structure #240
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eunjae-lee
force-pushed
the
EXT-1887-change-folder-structure-regarding-helpers
branch
from
a22c015 to
8db177e
Compare
| yarn eslint packages/field-plugin --ignore-pattern "packages/field-plugin/helpers/" | ||
| yarn workspaces foreach --include "helper-*" run lint |
There was a problem hiding this comment.
- line 27: ignore helpers from eslint
- line 28: run eslint for helpers with their own configs
There was a problem hiding this comment.
Why should they run separately?
Does this not solve the problem:
helper-vue3/.eslintrc.json
{
"root": true,
...
}There was a problem hiding this comment.
It didn't work. As far as I understand, the moment you run yarn eslint packages/field-plugin, it loads the root eslint config and apply it to all the files below. That root: true prevents your eslint process from "going up". So I had to separate them to make them work. Maybe I should just ignore the helpers in the root eslint config, so that I don't have to explicitly exclude them in the command line?
eunjae-lee
requested review from
a team and
johannes-lindgren
and removed request for
a team
|
@BibiSebi this has changed since you worked on it :) |
| yarn eslint packages/field-plugin --ignore-pattern "packages/field-plugin/helpers/" | ||
| yarn workspaces foreach --include "helper-*" run lint |
There was a problem hiding this comment.
Why should they run separately?
Does this not solve the problem:
helper-vue3/.eslintrc.json
{
"root": true,
...
}
eunjae-lee
deleted the
EXT-1887-change-folder-structure-regarding-helpers
branch
What?
This PR changes the folder structure for the helpers as discussed in #224
Why?
JIRA: EXT-1887
How to test? (optional)