feat(cli): deploy command including org scope #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added logic to be able to add plugins to an organization - also added text to show user where the plugin can be found inside organization
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
After merging, the version of CLI still needs to be bumped and a new release created |
eunjae-lee
reviewed
Jul 20, 2023
packages/cli/src/commands/deploy.ts
Outdated
| !accessibleToMyPlugins && | ||
| !accessibleToPartnerPortal && | ||
| !accessibleToOrganizationPortal | ||
| ) { | ||
| console.error( | ||
| red('[ERROR]'), | ||
| `The token appears to be invalid as it does not have access to either My Plugins or the plugins on the Partner Portal.`, |
There was a problem hiding this comment.
We need to include the organization portal here! :)
There was a problem hiding this comment.
true :D haha let me quickly add it
BibiSebi
deleted the
EXT-1849-add-new-option-to-deploy-field-plugins-to-an-organization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Since past 2 weeks a new feature has been added to the product where organizations are able to create their own field plugins. For this new feature a new API endpoint has been added so we need to consider it inside our CLI to give the user the option to deploy to an organisation.
Why?
JIRA: EXT-1849
How to test? (optional)