Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): remove unnecessary install command in monorepo and provide docs #230

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

eunjae-lee
Copy link
Contributor

What?

This PR removes unnecessary npm install, yarn install, or pnpm install during the monorepo creation process, because the install command is called right after adding an actual field plugin package.

It also provides a link to doc regarding monorepo.

Why?

JIRA: EXT-1818

How to test? (optional)

@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plugin-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 3:50pm

@eunjae-lee eunjae-lee marked this pull request as ready for review July 17, 2023 15:49
@eunjae-lee eunjae-lee requested a review from BibiSebi July 17, 2023 15:49
Copy link
Contributor

@BibiSebi BibiSebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wohoo, looking good 👍

@eunjae-lee eunjae-lee merged commit dba06d2 into main Jul 18, 2023
@eunjae-lee eunjae-lee deleted the EXT-1818-more-explanation-on-monorepo branch July 18, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants