Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common): clean up scripts to build and copy helpers #227

Merged
merged 5 commits into from
Jul 17, 2023

Conversation

eunjae-lee
Copy link
Contributor

What?

As a follow-up of #224 , this PR cleans up scripts to build and copy helpers.

@vercel
Copy link

vercel bot commented Jul 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plugin-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2023 8:46am

@eunjae-lee eunjae-lee marked this pull request as ready for review July 13, 2023 08:41
@eunjae-lee eunjae-lee requested a review from BibiSebi July 13, 2023 08:41
@@ -0,0 +1,7 @@
#!/usr/bin/env bash

mkdir ./packages/field-plugin/dist/{react,vue3}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:O oh nice, did not know this syntax works

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew about this, but this is my first time actually using it 😍

Copy link
Contributor

@BibiSebi BibiSebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat change 🥇

@eunjae-lee eunjae-lee merged commit 8878147 into main Jul 17, 2023
@eunjae-lee eunjae-lee deleted the chore/clean-up-helper-scripts branch July 17, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants