fix(template): remove non-existing properties correctly in vue 3 template #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey Eunjae, I remember when i tried copy pasting these changes, the template example did not work? Could you rebase your branch to match with main and apply it to the new vue3. submodule and test it? In case you do not have time I can also check it :) |
eunjae-lee
force-pushed
the
EXT-1817-vue-3-hook-appends-options
branch
from
f9921d7 to
b336e6b
Compare
Hey @BibiSebi I just tested it's working here. Maybe when you copied it over to your branch, something was different there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes properties that no longer exist in
FieldPluginProviderof the vue 3 template.Why?
JIRA: EXT-1817
The Jira ticket mentions the changing
options, but actually the same problem happened toplugin.data.contenttoo.How to test? (optional)