feat(CLI): remove --publish

storyblok · Oct 3, 2024 · a5a690e · a5a690e
1 parent 2d2718a
commit a5a690e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 13 deletions.
diff --git a/packages/cli/src/commands/deploy/helper.ts b/packages/cli/src/commands/deploy/helper.ts
@@ -32,7 +32,7 @@ type UpsertFieldPluginFunc = (args: {
   packageName: string
   output: string
   skipPrompts: undefined | boolean
-  publish: undefined | boolean
+  publish: boolean
 }) => Promise<{ id: number }>
 
 type GetPackageName = (params: {
@@ -422,20 +422,16 @@ export const createFieldPlugin = async (
 // Publish Logic
 
 type CheckPublish = (params: {
-  publish: undefined | boolean
+  publish: boolean
   skipPrompts: undefined | boolean
 }) => Promise<boolean>
 
 export const checkPublish: CheckPublish = async ({ publish, skipPrompts }) => {
-  if (skipPrompts === true) {
-    //NOTE: Publish true is the default value
-    return publish || true
-  }
-
-  if (publish !== undefined) {
+  if (skipPrompts === true || publish === false) {
     return publish
   }
 
+  //NOTE: In interactive mode where --no-publish is not provided, the user is asked to confirm the publish action.
   const publishConfirmation = await confirmPublish()
   return publishConfirmation
 }

diff --git a/packages/cli/src/commands/deploy/index.ts b/packages/cli/src/commands/deploy/index.ts
@@ -15,7 +15,7 @@ import { Scope } from '../../storyblok/storyblok-client'
 export type DeployArgs = {
   skipPrompts: boolean
   dir: string
-  publish: undefined | boolean
+  publish: boolean
   name: undefined | string
   token: undefined | string
   output: undefined | string

diff --git a/packages/cli/src/main.ts b/packages/cli/src/main.ts
@@ -60,10 +60,6 @@ export const createCLI = () => {
       '--name <value>',
       'name of plugin (Lowercase alphanumeric and dash)',
     )
-    .option(
-      '--publish',
-      'This flag is only applied when a plugin is being updated! Publishes a new version of the plugin.',
-    )
     .option(
       '--no-publish',
       'This flag is only applied when a plugin is being updated! Uploads field plugin but does not publish a new version.',