feat: apply suggestions from code review by Demetrius

Co-authored-by: Demetrius Feijóo <[email protected]>
storyblok · Jan 3, 2025 · 77e0809 · 77e0809
1 parent 6dbc637
commit 77e0809
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/...s/field-plugin/src/messaging/pluginMessage/containerToPluginMessage/LoadedMessage.test.ts b/...s/field-plugin/src/messaging/pluginMessage/containerToPluginMessage/LoadedMessage.test.ts
@@ -173,7 +173,7 @@ describe('LoadedMessage', () => {
         }),
       ).toEqual(true)
     })
-    it('is false', () => {
+    it('is a boolean and it is false', () => {
       expect(
         isLoadedMessage({
           ...stub,

diff --git a/...d-plugin/src/messaging/pluginMessage/containerToPluginMessage/StateChangedMessage.test.ts b/...d-plugin/src/messaging/pluginMessage/containerToPluginMessage/StateChangedMessage.test.ts
@@ -173,7 +173,7 @@ describe('StateChangedMessage', () => {
         }),
       ).toEqual(true)
     })
-    it('is false', () => {
+    it('is a boolean and it is false', () => {
       expect(
         isStateMessage({
           ...stub,

diff --git a/...ield-plugin/src/messaging/pluginMessage/pluginToContainerMessage/GetUserContextMessage.ts b/...ield-plugin/src/messaging/pluginMessage/pluginToContainerMessage/GetUserContextMessage.ts
@@ -3,7 +3,7 @@ import { isMessageToContainer, MessageToContainer } from './MessageToContainer'
 export type GetUserContextMessage = MessageToContainer<'getUserContext'> & {
   // Previously, debounced message was the default behavior.
   // That debouncing implementation can be problematic, for example,
-  // when multiple field plugin instances request for context.
+  // when multiple field plugin instances request for user context.
   debounce: false
 }
 

diff --git a/packages/sandbox/src/components/FieldPluginSandbox.tsx b/packages/sandbox/src/components/FieldPluginSandbox.tsx
@@ -269,11 +269,12 @@ const useSandbox = (
   )
 
   const onUserContextRequested = useCallback(
-    () =>
+    (message: GetUserContextMessage) =>
       dispatchUserContextRequest({
         uid,
         action: 'get-user-context',
         user,
+        callbackId: message.callbackId,
       }),
     [uid, dispatchUserContextRequest, user],
   )