Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing carousel #113

Merged
merged 9 commits into from
Jun 25, 2020
Merged

Fixing carousel #113

merged 9 commits into from
Jun 25, 2020

Conversation

dijs
Copy link
Contributor

@dijs dijs commented Jun 22, 2020 •
edited
Loading

No description provided.

@dijs
Fixing carousel
9a2c919 
Making the slides virtual
@dijs dijs added the wip label Jun 22, 2020
@dijs dijs removed the wip label Jun 23, 2020
@dijs dijs requested a review from kevhender June 23, 2020 11:46
markbrocato
markbrocato requested changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@markbrocato markbrocato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but you no longer have 100% coverage on Carousel. Please fix that.

@markbrocato
Copy link
Contributor

Also, I see this error in the chrome console when I go backwards using the arrows:

react_devtools_backend.js:6 Material-UI: the value provided `-2` to the Tabs component is invalid.
None of the Tabs children have this value.
You can provide one of the following values: 0, 1, 2.

@dijs
Copy link
Contributor Author

dijs commented Jun 24, 2020

@markbrocato I will take a look at that. I thought I already fixed that error, strange.

@dijs dijs requested a review from markbrocato June 24, 2020 14:07
@markbrocato markbrocato merged commit 0e22335 into master Jun 25, 2020
@markbrocato markbrocato deleted the fixing-carousel branch June 25, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbrocato markbrocato markbrocato approved these changes

@kevhender kevhender Awaiting requested review from kevhender

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dijs @markbrocato