feat!: add size to store/remove receipt
#969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
changed the title
alanshaw
changed the title
store/remove receipt
travis
approved these changes
Oct 12, 2023
This was referenced Oct 12, 2023
alanshaw
pushed a commit
that referenced
this pull request
Oct 13, 2023
🤖 I have created a release *beep* *boop* --- ## [10.0.0](capabilities-v9.5.0...capabilities-v10.0.0) (2023-10-12) ### ⚠ BREAKING CHANGES * Returning the `size` means that we need to fetch the stored item beforehand, and if it does not exist throw a `StoreItemNotFound` error. This is a change from the current behaviour which returns successfully even if the item is not present in the space. ### Features * add size to `store/remove` receipt ([#969](#969)) ([d2100eb](d2100eb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
alanshaw
pushed a commit
that referenced
this pull request
Oct 18, 2023
🤖 I have created a release *beep* *boop* --- ## [6.0.0](upload-api-v5.9.0...upload-api-v6.0.0) (2023-10-13) ### ⚠ BREAKING CHANGES * Returning the `size` means that we need to fetch the stored item beforehand, and if it does not exist throw a `StoreItemNotFound` error. This is a change from the current behaviour which returns successfully even if the item is not present in the space. ### Features * add size to `store/remove` receipt ([#969](#969)) ([d2100eb](d2100eb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
alanshaw
pushed a commit
that referenced
this pull request
Oct 18, 2023
🤖 I have created a release *beep* *boop* --- ## [10.0.0](upload-client-v9.4.1...upload-client-v10.0.0) (2023-10-18) ### ⚠ BREAKING CHANGES * Returning the `size` means that we need to fetch the stored item beforehand, and if it does not exist throw a `StoreItemNotFound` error. This is a change from the current behaviour which returns successfully even if the item is not present in the space. ### Features * add size to `store/remove` receipt ([#969](#969)) ([d2100eb](d2100eb)) * upgrade to ucanto@9 ([#951](#951)) ([d72faf1](d72faf1)) ### Bug Fixes * upgrade to latest ts ([#962](#962)) ([711e3f7](711e3f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
alanshaw
pushed a commit
that referenced
this pull request
Oct 18, 2023
🤖 I have created a release *beep* *boop* --- ## [9.0.0](w3up-client-v8.1.0...w3up-client-v9.0.0) (2023-10-18) ### ⚠ BREAKING CHANGES * Returning the `size` means that we need to fetch the stored item beforehand, and if it does not exist throw a `StoreItemNotFound` error. This is a change from the current behaviour which returns successfully even if the item is not present in the space. ### Features * add size to `store/remove` receipt ([#969](#969)) ([d2100eb](d2100eb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Alan Shaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
sizeproperty to thestore/removereceipt. This is so we can account for removals properly.This also moves the
store/*andupload/*receipt types into the@web3-storage/capabilitiespackage to be consistent with the rest of them. This accounts for much of the churn here.TODO: update https://github.com/web3-storage/w3infra/blob/9f0c50dd2cf4adec616483d7c8d29cfdec03129c/ucan-invocation/functions/space-metrics-store-remove-size-total.js#L43-L51 (in separate PR)
BREAKING CHANGE: Returning the
sizemeans that we need to fetch the stored item beforehand, and if it does not exist throw aStoreItemNotFounderror. This is a change from the current behaviour which returns successfully even if the item is not present in the space.