feat: access/claim only claims delegations with the correct audience
#448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobengo
changed the title
access/claim only claims delegations with the correct audience
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 17, 2025
unpin package numbers and get rid of extra CHANGELOG noise
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
unpin package numbers and get rid of extra CHANGELOG noise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
Motivation:
access/claiminaccess-api#394 . They don't need to be a part of feat: handle access/delegate invocations without error #427, which is motivated by access-api can handleaccess/delegateinvocations fordid:key#425. I don't mind putting them alltogether, but I'm holding these out while iterating on feat: handle access/delegate invocations without error #427 based on review