feat: add /reproduce-cloudflare-error route to access-api #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cloudflare support
hugomrdias
approved these changes
Jan 20, 2023
gobengo
pushed a commit
that referenced
this pull request
Jan 23, 2023
🤖 I have created a release *beep* *boop* --- ## [4.8.0](access-api-v4.7.0...access-api-v4.8.0) (2023-01-23) ### Features * add /reproduce-cloudflare-error route to access-api ([#380](#380)) ([edf925f](edf925f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
added a commit
that referenced
this pull request
Apr 11, 2023
Motivation: * cloudflare support asked for a URL to reproduce the undelrying cause of #363 * this adds a route just for that. once they use it to reproduce and diagnose, we remove it
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [4.8.0](access-api-v4.7.0...access-api-v4.8.0) (2023-01-23) ### Features * add /reproduce-cloudflare-error route to access-api ([#380](#380)) ([0eb3d5f](0eb3d5f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 17, 2025
Per storacha#296, update linter configs to match https://github.com/web3-storage/w3protocol, minus prettier because it wouldn't stop having bare knuckle boxing matches with eslint that I got sick of mediating. Use @hugomrdias's `hd-scripts` configs, but turn off a few eslint rules that either a) I didn't like (no-negated-conditions, no-null) or b) feel duplicative in TypeScript (all of the jsdoc rules). Also turn off `import/extensions` because as far as I can tell it recommends the wrong thing. Without disabling these rules I got errors like this: <img width="971" alt="Screenshot 2023-02-07 at 4 32 03 PM" src="https://user-images.githubusercontent.com/1113/217206052-f8c9422a-8a86-45bc-8902-b255515f63e3.png"> I'm definitely open to leaving some of these on if anyone likes them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
HandlerExecutionError+HTTPError#363